decorator validates add order parameter#1720
Closed
ficapy wants to merge 1 commit intomarshmallow-code:devfrom
Closed
decorator validates add order parameter#1720ficapy wants to merge 1 commit intomarshmallow-code:devfrom
ficapy wants to merge 1 commit intomarshmallow-code:devfrom
Conversation
Member
|
Thanks for the PR. This was also added in #600 but there's still discussion needed on whether this is something we want to add to core. Let's continue discussion on that PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows validate to be executed in order
For example, if field A needs to query the database when validating, and field B relies on the results of field A's query,
then validation function A needs to query the database and validation function B needs to query the database if there is no guarantee that A will be executed first.
Or merge validation functions A, B together, or some other very ugly solution
Adding the order parameter would look like this