Skip to content

Add missing Lucene 10 migration tasks #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
markrmiller merged 1 commit into from
Aug 1, 2025
Merged

Add missing Lucene 10 migration tasks #11

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 26 additions & 0 deletions lucene_10_migration.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,6 +123,25 @@
- **Dependencies:** None


- [ ] **HIGH** TermInSetQuery constructors now require a `Collection<BytesRef>`.
- **Impact:** Instantiations using `new TermInSetQuery(field, BytesRef...)` no longer compile.
- **Location:** `solr/core/src/java/org/apache/solr/schema/FieldType.java`, `solr/core/src/java/org/apache/solr/handler/component/ExpandComponent.java`, `solr/core/src/java/org/apache/solr/search/TermsQParserPlugin.java`, `solr/core/src/java/org/apache/solr/search/join/GraphEdgeCollector.java`.
- **Lucene Change:** `CHANGES.txt` lines 430-436.
- **Action Required:** Pass a `Collection<BytesRef>` or `PrefixCodedTerms` to the constructor.
- **Dependencies:** None
- [ ] **HIGH** `TopDocs.maxScore` field removed.
- **Impact:** Calls to `getMaxScore()` or accessing `maxScore` cause errors.
- **Location:** `solr/core/src/java/org/apache/solr/handler/component/QueryComponent.java`, `solr/core/src/java/org/apache/solr/client/solrj/embedded/EmbeddedSolrServer.java`, `solr/core/src/java/org/apache/solr/handler/component/MoreLikeThisComponent.java`, `solr/core/src/java/org/apache/solr/search/SolrIndexSearcher.java`.
- **Lucene Change:** `MIGRATE.md` lines 606-618.
- **Action Required:** Compute max score via a separate search or collector and store externally.
- **Dependencies:** None
- [ ] **HIGH** `LowerCaseTokenizer` removed from Lucene.
- **Impact:** `LowerCaseTokenizerFactory` and configs referencing it will fail to compile or load.
- **Location:** `solr/core/src/java/org/apache/solr/analysis/LowerCaseTokenizerFactory.java`, schema files.
- **Lucene Change:** `MIGRATE.md` lines 676-684.
- **Action Required:** Replace with `LetterTokenizer` followed by `LowerCaseFilter` or custom filter chain.
- **Dependencies:** None

## Behavioral Changes
- [ ] **HIGH** Faceting: `LongRangeFacetCounts#getTopChildren` and `DoubleRangeFacetCounts#getTopChildren` now return only the top‑n ranges.
- **Impact:** Range facet output may differ from 9.x behaviour.
Expand Down Expand Up @@ -154,6 +173,13 @@
- **Lucene Change:** `MIGRATE.md` lines 88‑91.
- **Action Required:** Review analysis chain and reindex if necessary or clone the 9.x `PersianAnalyzer` via `CustomAnalyzer`.
- **Dependencies:** None
- [ ] **HIGH** Block-join highlighting requires custom extractors.
- **Impact:** Default Highlighter and FastVectorHighlighter no longer handle `ToParentBlockJoinQuery`.
- **Location:** `solr/core/src/java/org/apache/solr/highlight/DefaultSolrHighlighter.java`.
- **Lucene Change:** `MIGRATE.md` lines 687-694.
- **Action Required:** Implement a custom `WeightedSpanTermExtractor` or `FieldQuery` to support block-join queries.
- **Dependencies:** None

- [ ] **HIGH** Automaton-based queries require explicit determinization.
- **Impact:** Automaton queries may behave incorrectly without calling `Operations.determinize()`.
- **Location:** `SolrQueryParserBase`, `TermsQParserPlugin`, `GraphEdgeCollector`, and any RegExp/AutomatonQuery usages.
Expand Down
Loading