Skip to content

Add missing Lucene 10 migration tasks #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
markrmiller merged 1 commit into from
Aug 1, 2025
Merged

Add missing Lucene 10 migration tasks #10

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions lucene_10_migration.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,6 +108,20 @@
- **Lucene Change:** `MIGRATE.md` lines 149‑153.
- **Action Required:** Use `IndexSearcher#getTaskExecutor` when access to the executor is required.
- **Dependencies:** None
- [ ] **HIGH** Query rewrite API: Pass `IndexSearcher` instead of `IndexReader` to `Query#rewrite`.
- **Impact:** Existing calls to `.rewrite(IndexReader)` cause compilation errors.
- **Location:** `solr/core/src/java/org/apache/solr/query/FilterQuery.java`, `solr/core/src/java/org/apache/solr/update/DeleteByQueryWrapper.java`, `solr/core/src/java/org/apache/solr/search/ExportQParserPlugin.java`, `solr/core/src/java/org/apache/solr/search/MatchCostQuery.java`, `solr/core/src/java/org/apache/solr/search/WrappedQuery.java`, `solr/core/src/java/org/apache/solr/search/AbstractReRankQuery.java`, `solr/core/src/java/org/apache/solr/search/JoinQuery.java`.
- **Lucene Change:** `CHANGES.txt` lines 404-409.
- **Action Required:** Update call sites to use `IndexSearcher` and adjust surrounding logic.
- **Dependencies:** None

- [ ] **HIGH** Suggesters weight API: adapt to `Long` and `double` return types.
- **Impact:** Code using primitive `long` may fail to compile or behave incorrectly.
- **Location:** `solr/core/src/java/org/apache/solr/spelling/suggest/jaspell/JaspellLookup.java` and any custom suggester implementations.
- **Lucene Change:** `MIGRATE.md` lines 666-670.
- **Action Required:** Unbox or convert returned weight values and adjust variable types.
- **Dependencies:** None


## Behavioral Changes
- [ ] **HIGH** Faceting: `LongRangeFacetCounts#getTopChildren` and `DoubleRangeFacetCounts#getTopChildren` now return only the top‑n ranges.
Expand Down
Loading