fixes & enhancements relating to null covar of imbalances, svg's from base R plot methods#143
Open
benthestatistician wants to merge 12 commits intomarkmfredrickson:mainfrom
Open
fixes & enhancements relating to null covar of imbalances, svg's from base R plot methods#143benthestatistician wants to merge 12 commits intomarkmfredrickson:mainfrom
benthestatistician wants to merge 12 commits intomarkmfredrickson:mainfrom
Conversation
also avoids error in cases with an NA in the std.diff column
... I think. To be be tested by CI but I can't confirm locally
namely, edge case that variable names of bal plot is a length-0 vector
a crude adjustment only
As in reported balanceTest results, intercepts and not-missing indicators that only ever take the value 1 get removed. Now this is also done with the null covariance of balance comparisons that is returned invisibly as an attribute.
... are now documented in balT inline comments, one test
W/ a bit more to be done to make corresp p-vals equal NA not 1. Adding but commenting out tests for that behavior.
With const variables, overall p-value is now also NA
Deliver message not warning
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adjustments having to do with idiosyncratic use cases. No rush about review or pull.