Open
Conversation
Just pointing to releases page to avoid having to update the tag name in future releases.
|
Copyright Validation Results ⏭️ Skipped (Excluded) Files
✅ All files have valid copyright headers! |
Contributor
There was a problem hiding this comment.
Pull request overview
Updates documentation to reduce release-specific maintenance and to correct the documented defaults for how embeddings are stored when using the embedder feature.
Changes:
- Update Spark integration docs to link to the GitHub releases index instead of a specific tag.
- Update embedder docs to reflect current default embedding field/element names and the default XML namespace.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| docs/spark-integration.md | Points users to the general GitHub releases page for downloading the Flux uber-jar. |
| docs/import/embedder/embedder.md | Corrects documented defaults for JSON/XML embedding storage (name + XML namespace). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
242
to
+255
| @@ -250,9 +250,9 @@ Flux will then create an array with the name provided to the option and store ea | |||
|
|
|||
| ### XML documents | |||
|
|
|||
| By default, Flux will store an embedding in a new element named `embedding` that is added to the chunk element. The new | |||
| element will have an empty namespace value. The embedding array is serialized to a string - so that it begins with `[` | |||
| and ends with `]` - and stored as the text node of the `embedding` element. | |||
| By default, Flux will store an embedding in a new element named `vector` that is added to the chunk element. The new | |||
| element will default to a namespace of `http://marklogic.com/vector`. The embedding array is serialized to a string - so that it begins with `[` | |||
| and ends with `]` - and stored as the text node of the `vector` element. | |||
Comment on lines
38
to
+39
| To use Flux with `spark-submit`, first download the `marklogic-flux-2.1.0-all.jar` file from the | ||
| [GitHub release page](https://github.com/marklogic/flux/releases/tag/2.0.0). This jar file includes Flux and all of | ||
| [GitHub release page](https://github.com/marklogic/flux/releases). This jar file includes Flux and all of |
|
|
||
| To use Flux with `spark-submit`, first download the `marklogic-flux-2.1.0-all.jar` file from the | ||
| [GitHub release page](https://github.com/marklogic/flux/releases/tag/2.0.0). This jar file includes Flux and all of | ||
| [GitHub release page](https://github.com/marklogic/flux/releases). This jar file includes Flux and all of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just pointing to releases page to avoid having to update the tag name in future releases.