Added optional parameter to allow setting of the tariff code.#23
Open
Quietus wants to merge 1 commit intomarkgdev:masterfrom
Open
Added optional parameter to allow setting of the tariff code.#23Quietus wants to merge 1 commit intomarkgdev:masterfrom
Quietus wants to merge 1 commit intomarkgdev:masterfrom
Conversation
|
Agile Octopus has recently been updated and the new tariff code below can be used perfectly with this PR
This PR would solve the issue of rates being capped at 35p. Can we get this merged @markgdev? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Over time, Octopus have introduced some new variants on the tariff for Agile, depending on when you signed up or your contract updated you may not be on the same one so I've added an optional parameter for the code to load the one you want the data for - can be set to any of these, will default to AGILE-18-02-21 (original behaviour).
AGILE-18-02-21 – The original version capped at 35p per unit
AGILE-22-07-22 – The cap rose to 55p
AGILE-22-08-31 – The cap was increased to 78p
AGILE-VAR-22-10-19 – This version raised the cap to £1 per unit and also introduced a new formula.
AGILE-FLEX-22-11-25 – Cap stays at £1 per unit but new formula only deducts 17.9p from higher unit prices.