Made it so TidyManaged will automatically switch between the 32bit and 64bit version of libtidy.#5
Open
freethenation wants to merge 2 commits intomarkbeaton:masterfrom
Open
Made it so TidyManaged will automatically switch between the 32bit and 64bit version of libtidy.#5freethenation wants to merge 2 commits intomarkbeaton:masterfrom
freethenation wants to merge 2 commits intomarkbeaton:masterfrom
Conversation
…d 64bit version of libtidy. The 32bit version of libtidy should be named "libtidy32.dll" and the 64bit version of libtidy should be named "libtidy64.dll"
… log. Libtidy used to write its error log to standard out. Also added an overloaded of CleanAndRepair that allows the error log to be written to a stream.
Owner
|
Hi there - thanks for this. I don't suppose you've tested it on non-Windows platforms? I suppose we can remap the DllImport library names via some sort of Mono-specific configuration in an assembly.config file... although it'd be nice if that wasn't necessary. Let me know & I'll have a look if you haven't tested already. Thanks, |
Author
|
I have not tested my changes on mono. My changes should not significantly change how libtidy loads on mono. Something similar to the config section below should work. <configuration> Regards, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Made it so TidyManaged will automatically switch between the 32bit and 64bit version of libtidy. The 32bit version of libtidy should be named "libtidy32.dll" and the 64bit version of libtidy should be named "libtidy64.dll"