Update fbcopy.cpp

[massmarz]

Added default value when A option is set

[Copilot]

Pull request overview

This PR adds support for extracting and including default column values in the generated SQL statements when using the -A (ALTER) operation in fbcopy. The changes involve fetching the RDB$DEFAULT_SOURCE field from Firebird system tables and inserting it into the generated DDL output between the column type and NOT NULL constraint.

Key changes:

• Added missing tr2->Commit() call to properly commit the destination database transaction in copyGeneratorValues()
• Modified SQL query to fetch RDB$DEFAULT_SOURCE from system tables
• Updated getDatatype() function to extract and format default values for all column types

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

[nitpick] The else clause only executes when the default is null OR when not_nulls is false, but only initializes default_source in those cases. Consider initializing default_source to empty string at declaration (line 962) and only populating it when conditions are met. This makes the logic clearer and avoids the unnecessary else clause.

Suggested change

	std::string default_source;
	if (!st1->IsNull(7) && not_nulls) {
	st1->Get(7, default_source);
	}
	else
	default_source = "";
	std::string default_source = "";
	if (!st1->IsNull(7) && not_nulls) {
	st1->Get(7, default_source);
	}

[Copilot]

Inconsistent indentation: this line uses tabs instead of spaces. The codebase consistently uses spaces for indentation (4 spaces per level). Replace the leading tab with 8 spaces to match surrounding code.

Suggested change

	retval << " " << default_source << " ";
	retval << null_flag;
	retval << " " << default_source << " ";
	retval << null_flag;

[Copilot]

Inconsistent indentation: this line uses tabs instead of spaces. The codebase consistently uses spaces for indentation (4 spaces per level). Replace the leading tab with 8 spaces to match surrounding code.

Suggested change

	retval << " " << default_source << " ";
	retval << null_flag;
	retval << " " << default_source << " ";
	retval << null_flag;

[Copilot]

Potential issue: default_source may be empty, resulting in extra spaces in the output (e.g., 'Integer NOT NULL'). Consider conditionally appending default_source only when it's non-empty, or handle the spacing logic more carefully to avoid double spaces.

[Copilot]

Inconsistent indentation: this line uses tabs instead of spaces. The codebase consistently uses spaces for indentation (4 spaces per level). Replace the leading tabs with 12 spaces to match the expected indentation level.

Suggested change

	retval << " " << default_source << " ";
	retval << null_flag;
	retval << " " << default_source << " ";
	retval << null_flag;

[Copilot]

Inconsistent indentation: this line uses tabs instead of spaces. The codebase consistently uses spaces for indentation (4 spaces per level). Replace the leading tabs with 16 spaces to match the expected indentation level.

Suggested change

	retval << null_flag;
	retval << null_flag;

[Copilot]

Potential issue: default_source may be empty, resulting in extra spaces in the output (e.g., 'Decimal(18,2) NOT NULL'). Consider conditionally appending default_source only when it's non-empty, or handle the spacing logic more carefully to avoid double spaces.

[Copilot]

Potential issue: default_source may be empty, resulting in extra spaces in the output (e.g., 'Varchar(50) NOT NULL'). Consider conditionally appending default_source only when it's non-empty, or handle the spacing logic more carefully to avoid double spaces. A better approach would be: if (!default_source.empty()) retval << ' ' << default_source;