Open
Conversation
Collaborator
ヒント
|
nihei-shunsuke
force-pushed
the
shunsuke
branch
from
0b96d37 to
9e20b47
Compare
Collaborator
Author
|
tomu28
requested changes
Jan 31, 2021
| text-align: center; | ||
| } | ||
| .App{ | ||
|
|
| Learn React | ||
| </a> | ||
| </header> | ||
| <Card /> |
| import './App.css'; | ||
|
|
||
| import Card from './component/Card'; | ||
| function App() { |
Collaborator
There was a problem hiding this comment.
[Nits]
import文の後に1行改行があると見やすいね
| import Sukiya from './img/sukiya.png'; | ||
| import Wego from './img/wego.png'; | ||
| import Earth from './img/earth.jpg'; | ||
| import GU from './img/GU.png'; |
| {img: Earth, alt:'earth', shop:'アースミュージック＆エコロジー 金沢フォーラス店', distance:6.7}, | ||
| {img: GU, alt:'GU', shop:'GU イオンタウン金沢示野店', distance:8.3} | ||
| ]; | ||
|
|
Collaborator
There was a problem hiding this comment.
Suggested change
[Nits]
意図がなければ削除しても🙆♂️
| class Card extends Component { | ||
| render() { | ||
| return ( | ||
| <div> |
| flex-wrap: wrap; | ||
| justify-content: space-between; | ||
| padding: 2.8125rem 0 0 4.375rem; | ||
| } |
Collaborator
There was a problem hiding this comment.
[Must]
全体的にインデントが1レベルずれているので直そう👍
tomu28
reviewed
Jan 31, 2021
| @@ -1,8 +1,7 @@ | |||
| .App{ | |||
|
|
|||
| /* .App{ | |||
Collaborator
There was a problem hiding this comment.
[Imo]
今後使用するなど意図がなければ削除していいよ👍
tomu28
reviewed
Jan 31, 2021
| class Card extends Component { | ||
| render() { | ||
| return ( | ||
| <div className="container"> |
tomu28
reviewed
Jan 31, 2021
| font-size: 1.875rem; | ||
| color: #696969; | ||
| } | ||
| .container { |
tomu28
reviewed
Jan 31, 2021
| </div> | ||
| </a> | ||
| </div> | ||
| ))} |
Collaborator
There was a problem hiding this comment.
[Nits]
ここのインデントずれているね😅
ESLintを導入しよう👍
nihei-shunsuke
force-pushed
the
shunsuke
branch
from
e1db5cd to
0897337
Compare
nihei-shunsuke
force-pushed
the
shunsuke
branch
from
44cc1b4 to
1f9a943
Compare
Collaborator
|
@nihei-shunsuke |
tsuru-kazu
previously approved these changes
Feb 2, 2021
Owner
tempUIディレクトリをマージして以降ニケがリモートマスターのブランチを一度も取り込んだ形跡がNetworkグラフに出ていなかったので恐らくリモートのマスターを取り込めば出てくると思います。 |
Owner
|
@nihei-shunsuke |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cardコンポーネントを作成し、文字のずれを修正
App.cssでCardコンポーネントを中央に揃えた（本当は縦二列にしたかった）