fix(day-diet): refetch data after accepting day change#1028
Merged
marcuscastelo merged 2 commits intorc/v0.14.0from Jul 27, 2025
Merged
fix(day-diet): refetch data after accepting day change#1028marcuscastelo merged 2 commits intorc/v0.14.0from
marcuscastelo merged 2 commits intorc/v0.14.0from
Conversation
- Add bootstrap() call to acceptDayChange() function to ensure day data is refetched when user accepts day change - Update test mocks to properly handle bootstrap function dependencies (showPromise and currentUserId) - Resolves issue where current day appears as non-existent after day change modal acceptance Fixes #1020
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes day change modal functionality by ensuring data is refetched from the server after accepting day change. Previously, when users clicked "Ir para [data] (Hoje)" to go to the current day, the target day was updated but day data remained stale, causing the current day to appear as non-existent even if it existed in the database.
Implementation Details
acceptDayChange()function: Addedbootstrap()call after updating target day to trigger day data refetchdayChangeDetection.test.tswith proper mocks forshowPromiseandcurrentUserIdto handle the new bootstrap callRoot Cause
The
acceptDayChangefunction insrc/modules/diet/day-diet/application/dayDiet.tsonly updated the target day without refetching day diets from the server, leaving the application with stale data that might not include the current day.Technical Changes
Testing
User Impact
Closes #1020