Add JRuby 10 support via FFI bindings#7
Closed
khasinski wants to merge 1 commit intomarcoroth:mainfrom
Closed
Conversation
JRuby cannot load C extensions, so this adds an FFI-based binding layer that loads the Go shared library directly. On CRuby, nothing changes -- the existing C extension path is used as before. - Add lib/lipgloss/ffi_bindings.rb with complete FFI bindings - Conditionally load FFI bindings on JRuby in lib/lipgloss.rb - Add go:build_shared Rake task for building .dylib/.so - Add ffi gem dependency (JRuby only) - Add jruby-10.0 to CI matrix
Contributor
Author
|
Talked to Marco and we decided to try a different approach, closing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
lib/lipgloss/ffi_bindings.rb) that load the Go shared library directly, enabling JRuby supportgo:build_sharedRake task for building.dylib/.so(vs the.aarchive used by the C extension)ffigem as a runtime dependency only on JRubyjruby-10.0to CI matrix with conditional steps (shared lib build, skip steep/rubocop)All 160 tests pass on both JRuby 10.0.3.0 and CRuby 4.0.
Test plan
go:build_sharedworks on Linux (CI will cover this)