fixnum and bignum deprecated in Ruby>=2.4#14
Open
boutil wants to merge 1 commit intomarcandre:masterfrom
Open
Conversation
Owner
|
Thanks for the PR. I'm ok with the changes, except about ignoring the two more commented lines about the validity and encoding of the string... This should ideally be working in all versions of Ruby... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
Running the tests in Debian (ruby2.7.1p83), I noticed two warnings and one test failure due to the deprecation of Fixnum and Bignum in favor of Integer since ruby 2.4(?).
In the first chunk, I removed the line containing Bignum, because it is exactly the same as the previous one, with Integer instead.
In the second chunk, I just replaced Fixnum by Integer
In the third one, I had to replace
assert_equalbyassert_matchbecause the output of the:generic_class_writerwas outputing two more commented lines about the validity and encoding of the string, which is ignored here for now.Cheers