Fix: list comprehension scope bug #12
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
❗ Problem
This PR fixes an issue where
locals()was used inside a list comprehension (inmodeling.ssf.model_spectrum, where the script checks that all input variables have the same number of elements).This issue was throwing
KeyErrors whenever themodel_spectrumfunction was called, as list comprehensions have their own local scope (see this Stack Overflow post) so it couldn't find any variables defined outside the comprehension.🔧 Fix
The fix is very simple -- take a snapshot of the local variables before executing the list comprehension:
With this change, the
model_spectrumfunction runs fine. There are no necessary API changes or changes to other parts of the codebase.