Fix/remove group and task listeners#90
Open
ofr1tz wants to merge 3 commits into
Open
Conversation
tnagorra
reviewed
Jul 10, 2026
| :tasks="tasks" | ||
| :tutorial="tutorial" | ||
| :tutorialTasks="tutorialTasks" | ||
| @created="handleTaskComponentCreated" |
Contributor
There was a problem hiding this comment.
We could also add to clear the whole component to be extra safe.
:key="group.groupId"
tnagorra
reviewed
Jul 10, 2026
| (g) => g.requiredCount > 0 && !completed.includes(g.groupId), | ||
| async bindTaskGroup() { | ||
| this.tasks = null | ||
| const snapshot = await get(getGroupsQuery(this.projectId)) |
Contributor
There was a problem hiding this comment.
Can we be sure that requiredCount has been updated at this point.
Although, it should be alright even if user is presented a page they have already swiped (sometimes).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace setting listeners to groups and tasks from project view by one-time reading to avoid potential misalignment of saved results.