Update translation strings from Transifex #2486
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
In the past we usually update the strings in the version bump pr as i did. The number of changes look pretty similar between our pr’s (#2492) so id assume you did it correctly. If you think it would be better to start updating the transifex strings in their own prs, i dont see a problem with that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Someone please tell me if this workflow is normally done differently (the docs are a little sparse).
I pulled the latest translation strings from Transifex, then ran a script to strip unused strings from the non-English files (so they all have the same keys as en-US.json). Then I reviewed the results, and pushed the resulting changes back up to Transifex.
The diff here includes both newly translated strings that were pulled down, and also deletions of strings that were unused, which is a little confusing. Sorry about that. In the future I'll split these types of changes into multiple PRs.