A11y safeguard: CI role check, remaining fixes, and coding rules#92
Merged
Conversation
- a11y_check.py: scans all Compose sources for .clickable/.combinedClickable
without a companion .semantics { role = Role.* }; exits 1 on any violation
- build.yml: run a11y_check.py as an early fast-fail step on every PR
- Fix remaining missed violations: archive dialog checkbox row, alarm-permission
list item, export-scope and export-format radio rows, theme-mode selector,
palette picker, app-icon picker, calendar day cells, and scrim dismiss overlay
https://claude.ai/code/session_01AeVcEqKNsCwEG6iSF4MYt4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to the a11y audit (PR #91). Adds safeguards so accessibility regressions are caught automatically on every PR, and fixes the remaining violations not caught in the first pass.
a11y_check.py: Python CI script that scans every Compose source file for.clickable/.combinedClickablemodifier chains missing a.semantics { role = Role.* }declaration. Fast-fails (no JDK required) so violations are surfaced before a full Gradle build.build.yml: Runspython3 a11y_check.py --fails-onlyas the first job step on every PR targetingmain.ManageCategoriesScreen.ktarchive dialog: "Don't show this again" Row now hasRole.Checkboxand innerCheckbox(onClick = null).SettingsScreen.ktreminder settings: alarm-permissionListItemnow hasRole.Button.SettingsScreen.ktexport sub-screen: export-scope rows haveRole.RadioButton+RadioButton(onClick = null); export-format rows the same.SettingsScreen.kttheme picker: mode selector Boxes haveRole.RadioButton;PaletteOptionColumn hasRole.RadioButton;IconChoiceCellColumn hasRole.RadioButton.CalendarGrid.kt:role = Role.Buttonadded insideclearAndSetSemanticsso day cells are reachable by keyboard and switch access.HomeScreen.kt: speed-dial scrim dismiss overlay now hasRole.ButtonandcontentDescription = "Close menu".Test plan
python3 a11y_check.pylocally — should print "All clean" with exit 0.https://claude.ai/code/session_01AeVcEqKNsCwEG6iSF4MYt4
Generated by Claude Code