Skip to content

Update package.json to fix Regular Expression Denial of Service in debug #706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
martinez-hugo wants to merge 3 commits into from
Closed

Update package.json to fix Regular Expression Denial of Service in debug #706

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ea6682b
Update package.json to fix Regular Expression Denial of Service in debug
martinez-hugo Dec 8, 2023
3ffcbaa
Updates
martinez-hugo Dec 8, 2023
978208d
Fix error
martinez-hugo Dec 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
78 changes: 62 additions & 16 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
"main": "./lib/node-pre-gyp.js",
"dependencies": {
"detect-libc": "^2.0.0",
"https-proxy-agent": "^5.0.0",
"https-proxy-agent": "^7.0.2",
"make-dir": "^3.1.0",
"node-fetch": "^2.6.7",
"nopt": "^5.0.0",
Expand Down
4 changes: 2 additions & 2 deletions test/proxy-bcrypt.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ const { createUnzip } = require('zlib');
const os = require('os');

const tar = require('tar-fs');
const Agent = require('https-proxy-agent');
const { HttpsProxyAgent } = require('https-proxy-agent');
Copy link
Collaborator

@benmccann benmccann Jun 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if this is being updated, wouldn't you also have to update lib/install.js?

const fetch = require('node-fetch');
const rimraf = require('rimraf');

Expand Down Expand Up @@ -73,7 +73,7 @@ test('setup proxy server', (t) => {
proxy.startServer({ port: proxyPort });
process.env.https_proxy = process.env.http_proxy = proxyServer;

options.agent = new Agent(proxyServer);
options.agent = new HttpsProxyAgent(proxyServer);

process.env.NOCK_OFF = true;

Expand Down