Scope temporary resources to the creating account#205
Merged
Conversation
5cd503f to
79e2e49
Compare
79e2e49 to
5aeab6f
Compare
jussi-sa
approved these changes
Jun 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Temporary resources (
mapbox://temp/...) created from large tool responses are now scoped to the account that created them, enforced on read.Changes
TemporaryResourcerecords the creating account (Mapbox username);temporaryResourceManager.create()accepts anowner.directions,isochrone, andstatic_map_imagetools pass the caller's account when storing a temporary resource.TemporaryDataResource.readresolves the requester the same way tools resolve their token (request auth, then the env token for stdio/single-user) and only returns the resource to the same account; otherwise it returns the standard not-found response — identical to a missing/expired resource.test/resources/temporary/TemporaryDataResource.test.ts(same-account read, cross-account denial, no-existence-oracle, env-token fallback, image blobs).Testing
npm test— full suite green (incl. the new file)npm run build,npm run lintdirections_toolcall creating a temp resource is readable by the creating account and returns not-found to a different account.