Skip to content

fix: handle CLI metadata flags#202

Merged
clarkemn merged 3 commits into
mapbox:mainfrom
Dolpme:fix/cli-metadata-flags
Jun 10, 2026
Merged

fix: handle CLI metadata flags#202
clarkemn merged 3 commits into
mapbox:mainfrom
Dolpme:fix/cli-metadata-flags

Conversation

@Dolpme

@Dolpme Dolpme commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

Summary

  • handle --help/-h and --version/-v before starting the MCP stdio server
  • reject unknown flags before server startup instead of hanging
  • keep existing server configuration flags flowing through to the current parser

Verification

  • npm test -- test/cli.test.ts
  • npm run build
  • npx prettier --check src/cli.ts src/index.ts test/cli.test.ts
  • npx eslint src/cli.ts src/index.ts test/cli.test.ts (0 errors; existing no-explicit-any warning in src/index.ts)
  • node dist/esm/index.js --help
  • node dist/esm/index.js --version
  • node dist/esm/index.js --bogus (exits 1)

Note: full npm run lint is blocked locally on Windows by repository-wide CRLF/Prettier line-ending errors in existing files outside this change.

@mattpodwysocki

Copy link
Copy Markdown
Contributor

Hey, the fix looks good! One thing we require before merging is a CHANGELOG entry under the Unreleased section at the top of CHANGELOG.md. Just a short line describing what changed and why is fine. Take a look at recent entries for the format.

@Dolpme

Dolpme commented Jun 8, 2026

Copy link
Copy Markdown
Contributor Author

Added the CHANGELOG.md entry under Unreleased -> Fixes in 0465519.

@mattpodwysocki mattpodwysocki left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the CHANGELOG entry. Looks good to me!

@clarkemn clarkemn merged commit 92c5a11 into mapbox:main Jun 10, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants