Mint GeoJSON preview token per request instead of caching#118
Merged
Conversation
The GeoJSON Preview UI resource reused a process-wide cached Mapbox GL token across requests. Mint a short-lived token per request and verify it belongs to the requesting account before embedding it. Adds tests for the resource.
zmofei
force-pushed
the
geojson-preview-token-per-request
branch
2 times, most recently
from
e9d1aea to
c118e6d
Compare
Valiunia
previously approved these changes
Jun 10, 2026
Valiunia
approved these changes
Jun 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The GeoJSON Preview UI resource (
ui://mapbox/geojson-preview/index.html) reused a process-wide cached Mapbox GL token across requests. This change mints a short-lived token per request and verifies the minted token belongs to the requesting account before embedding it in the returned HTML.Changes
pkpass-through, graceful degradation when minting fails, no-token case).Testing
npm test— newtest/resources/ui-apps/GeojsonPreviewUIResource.test.ts(6 cases), full suite greennpm run build,npm run lint