Skip to content
This repository was archived by the owner on Oct 14, 2025. It is now read-only.

Conversation

@SKalt
Copy link

@SKalt SKalt commented Oct 27, 2019

Addresses #56, #42, and #84.
Tests should all pass, but before approving, you should verify the raster layer works as expected. https://github.com/klokantech/vector-tiles-sample has an example raster .mbtiles that you can download, though it's only available at low zoom. I didn't write tests on top of that since the repo is unlicensed (though I did put in a ticket about that).

app.set('views', __dirname + '/views');
app.set('view engine', 'ejs');
app.use(express.static('public'));
app.use(express.static(__dirname + '/public'));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any idea where it pulls public from without setting _dirname + '/... ?

I just opened #96 which would conflict with this change, but without making the change mbview was broken for me.

Copy link
Author

@SKalt SKalt Jan 10, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My guess would express.static looks for "public" in your current working directory.

I couldn't find any docs with a definite answer.

None of

Copy link
Author

@SKalt SKalt Jan 10, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I couldn't find a single directory with that name, even in node_modules. You're definitely safe to nuke that line.

# in root of repo
docker run -it $(pwd):/root node:12-alpine sh
cd && rm -rf ./node_modules && npm ci && find . -type d -name public
echo $? && exit 

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants