Add plumbing for width and height in MapViz.create_html#183
Open
nneibaue wants to merge 4 commits intomapbox:masterfrom
Open
Add plumbing for width and height in MapViz.create_html#183nneibaue wants to merge 4 commits intomapbox:masterfrom
MapViz.create_html#183nneibaue wants to merge 4 commits intomapbox:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR allows the
widthandheightattributes of aMapVizinstance to be sent to the.mapcss class intemplates/main.html, thus allowingcreate_htmlto render non-fullscreen maps.Use-case: I am building html reports that utilize MapViz objects in conjunction with other plotting libraries (plotly, matplotlib, etc.), and I need the flexibility to change the size of the map for the html report.