Open
Conversation
…r legend CSS; also handles radius_function_type, height..., etc.
…hanges the legend item formats
ryanbaumann
reviewed
Oct 24, 2019
…ating the functiont types before displaying a map
… refine references to the expression type validators
Collaborator
Author
|
@ryanbaumann this seemed pretty similar to adding the 'step' expression mentioned in #169, so I've folded that in here along with some changes to the JS legend functions and viz.py. Added some tests and docs. Here's an example I've been using to test this out: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for 'identity' and 'step' expression types for
color_function_type,radius_function_typeorheight_function_type. Closes #144 and #169.