Closed
Conversation
…iz arguments; refine default color and line width handling
…iz arguments; refine default color and line width handling
… support-linestring
…ction and simple vector linestring
…p, choropleth, vector-linestring viz layers to 'collection'
Contributor
|
@akacarlyann thoughts on moving this work for multi-layers all to #129? Thanks for pushing your changes as a reference here, it's a valuable architecture reference. |
|
@ryanbaumann I'm in favor of closing this to pursue the api approach in #129. |
Contributor
|
Agreed. @narlesky closing, @akacarlyann let's move further work to #129 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Possible implementation for #34
Realized recently I hadn't uploaded my work on this yet. This is an option for collecting maps generated with the current Viz paradigm into a single visualization. I still think getting #23 done will be the most lightweight way to generate a multi-layer map with only a single MapViz object initialization.