fix: ensure feature is sorted by area (asc)#1539
Open
giulianovarriale wants to merge 1 commit intomapbox:mainfrom
Open
fix: ensure feature is sorted by area (asc)#1539giulianovarriale wants to merge 1 commit intomapbox:mainfrom
giulianovarriale wants to merge 1 commit intomapbox:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1540
When multiple polygons overlap, clicking on a smaller polygon could select the larger polygon instead. The
sortFeaturesfunction was intended to sort polygons by area (smallest first), butarea.geometry()was being called with a GeoJSON Feature wrapper instead of the raw geometry object. This was causing the area result to be always undefined and the sorting logic to fail.This PR fixes the area calculation by passing
feature.geometrydirectly, and swaps the polygon input order in the existing test so it no longer passes by coincidence. Previously, the test input was already in the expected order, so the broken sort still produced a green result.Before fix:
before-fix.mov
After fix:
after-fix.mov