[ci] Add a check to make sure we will not release v24.0 - v24.5 with wrong Turf dependency.#458
Merged
tatiana-yan merged 1 commit intomainfrom Apr 14, 2025
Conversation
tatiana-yan
force-pushed
the
common/tatiana-yan/CORESDK-3463-spike-release-fix
branch
from
441bd2d to
2110185
Compare
…wrong Turf dependency.
tatiana-yan
force-pushed
the
common/tatiana-yan/CORESDK-3463-spike-release-fix
branch
from
2110185 to
37c1f4f
Compare
tatiana-yan
changed the title
Kylmakalle
approved these changes
Apr 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now if we make PR from the old v24 branch to main we may release mapbox-common ios with wrong Turf dependency
The problem has been fixed since v24.6: https://github.com/mapbox/mapbox-sdk-common/pull/4664
patches prior to v24.6.x should be released from the dedicated branches (see 24.5.1 for reference: #455)
But to prevent incorrect releases I'm adding a jom and going to make in mandatory.
I tested it with PRs from branches with name release/v24.0.-test, release/v24.6.-test, worked fine:
fails for v24.0
https://app.circleci.com/pipelines/github/mapbox/mapbox-common-ios/1646/workflows/5a0d75de-a2dc-4851-8b0f-c103d9764fc6/jobs/4155
success for v24.6:
https://app.circleci.com/pipelines/github/mapbox/mapbox-common-ios/1645/workflows/61f463f9-b3ee-41ee-b9b7-688417e2ed0c/jobs/4152
success for the branch not starting with release (this one).