Fixed #listings div height #40
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#listings div was too large when screen width < 800px breakpoint shifted the locations to the bottom of the screen; when scrolling to the bottom of the div, some locations would not be visible.
Now, #listings div height will not exceed the available viewable screen height.
Note: The comment on line 20 snuck through and documents my hacky code tendencies and should be destroyed. I was calling getWindowDimensions() on line 35 and getting an incorrect height value, using window.onload = getWindowDimensions instead allowed document.querySelector('#sidebarA').clientHeight to get the correct value.
Happy New Year!