Skip to content

fix: don't consume clicks when no onClick given (fix #274)#337

Open
jacobq wants to merge 1 commit intomansona:mainfrom
jacobq:fix-click
Open

fix: don't consume clicks when no onClick given (fix #274)#337
jacobq wants to merge 1 commit intomansona:mainfrom
jacobq:fix-click

Conversation

@jacobq
Copy link
Contributor

@jacobq jacobq commented Mar 11, 2022

To avoid the problems described in #269 and #274 (that #270 was supposed to fix) this PR proposes making the handleOnClick function inert when @onClick is not provided.

Demo: https://github.com/jacobq/ecm-clickProblem

@jacobq
Copy link
Contributor Author

jacobq commented May 26, 2022

Alternatively, the event could be passed to the onClick handler so that the consumer can decide whether to preventDefault, stopPropagation, etc. as needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant