Added 'isDismissed' param to notification.onClick#203
Open
omairvaiyani wants to merge 1 commit intomansona:mainfrom
Open
Added 'isDismissed' param to notification.onClick#203omairvaiyani wants to merge 1 commit intomansona:mainfrom
omairvaiyani wants to merge 1 commit intomansona:mainfrom
Conversation
Owner
|
Hey @omairvaiyani thanks for the contribution 🎉 I think this is a pretty good addition and seems like it would be useful for other people too 🤔 Is there any chance that you could add a test for it? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated branch and resubmitting PR
Given that onClick is called regardless of where the user clicks the notification, determining their goal was hard. The notification object returned by onClick did not have the value dismiss on hand, as onClick ran before the notification was dismissed. Therefore, I was running a timer after onClick to see whether the user wanted to dismiss or interact. This also limited how many interactions we can add.