Open
Conversation
The project that I wish to use GdbCrashHandler in provides both qmake and cmake build systems so we need qmake project files as well. This PR attempts to provide them. It was necessary to modify the header inclusion for the QuaZip library for the `./lib/GdbCrashHandlerDialog.cpp` file, it seems that Debian Linux, at least, puts it in a `quazip` sub-directory. I also note that this library is at version 0.3.0 and that is what I specified in the QMake project file - so it build the chain of symbolic- links to the un-versioned `libGdbCrashHandler.so` using those numbers. However the Cmake project file produces version numbers based on a 1.0.0 semantic version number - I guess one of these is not right but it isn't precisely clear yet why a sub-unity version number is being used to produce a unity product version. Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
manisandro
reviewed
Jun 28, 2020
| #include <QUrlQuery> | ||
| #include <QUuid> | ||
| #include <quazipfile.h> | ||
| #include <quazip/quazipfile.h> |
Owner
There was a problem hiding this comment.
This won't work as a general upstream solution, i.e. other distros use quazip5/quazipfile.h. The proper way is for quazip-devel to ship a CMake module and/or pkg-config file which returns the include path. On Fedora, FindQuaZip5.cmake does this, but quazip does not seem to provide a pkg-config file (which is the typical way to include dependencies with qmake). You'll need to explicitly pass the include dir via QMAKE_CFLAGS env-var when building the project, or patch it locally.
Owner
|
The so version is unrelated to the project version number, it's just a three digit sequence according to https://semver.org/. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The project that I wish to use GdbCrashHandler in provides both qmake and cmake build systems so we need qmake project files as well. This PR attempts to provide them.
It was necessary to modify the header inclusion for the QuaZip library for the
./lib/GdbCrashHandlerDialog.cppfile, it seems that Debian Linux, at least, puts it in aquazipsub-directory.I also note that this library is at version 0.3.0 and that is what I specified in the QMake project file - so it buils the chain of symbolic-
links to the un-versioned
libGdbCrashHandler.sousing those numbers. However the Cmake project file produces version numbers based on a 1.0.0 semantic version number - I guess one of these is not right but it isn't precisely clear yet why a sub-unity version number is being used to produce a unity product version.Signed-off-by: Stephen Lyons slysven@virginmedia.com