fix: don't remove the leaf from the tree when fullscreening #965
Open
ernestoCruz05 wants to merge 1 commit into
Open
fix: don't remove the leaf from the tree when fullscreening #965ernestoCruz05 wants to merge 1 commit into
ernestoCruz05 wants to merge 1 commit into
Conversation
… windows doesnst split randomly
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently when toggling a window into fullscreen they are marked as not tiled and therefore removed from the binary tree making it so whenever they are toggled as not fullscreen they are not inserted in the correct branch:
2026-05-23.19-00-50.mp4
To fix this avoid removing the window from the binary tree if it is still visible on the current workspace and skip resizing it to a tiled container while it is in a fullscreen state:
2026-05-23.18-52-20.mp4