refactor: change fair/fairv to use a 2 level tree#938
Open
DuckTapeMan35 wants to merge 1 commit into
Open
Conversation
the idea is that we can step once through the tree to get the layout
(dfs) and since this makes it declarative resize can simply mutate the
tree and the arranger will handle the rest.
the tree looks a bit like:
FairState (root)
├── cols[0] { ratio: col_width_weight }
│ ├── row_ratios[0] row_height_weight
│ ├── row_ratios[1] row_height_weight
│ └── row_ratios[2] row_height_weight
├── cols[1] { ratio: col_width_weight }
│ ├── row_ratios[0] row_height_weight
│ └── row_ratios[1] row_height_weight
└── cols[2] { ratio: col_width_weight }
└── row_ratios[0] row_height_weight
DreamMaoMao
force-pushed
the
main
branch
3 times, most recently
from
c009ba2 to
f328c27
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the idea is that we can step once through the tree to get the layout (dfs) and since this makes it declarative resize can simply mutate the tree and the arranger will handle the rest.
the tree looks a bit like:
FairState (root)
├── cols[0] { ratio: col_width_weight }
│ ├── row_ratios[0] row_height_weight
│ ├── row_ratios[1] row_height_weight
│ └── row_ratios[2] row_height_weight
├── cols[1] { ratio: col_width_weight }
│ ├── row_ratios[0] row_height_weight
│ └── row_ratios[1] row_height_weight
└── cols[2] { ratio: col_width_weight }
└── row_ratios[0] row_height_weight