attempt to fix extractors and core#57
Open
i-am-fyre wants to merge 1 commit intomangosthree:masterfrom
Open
Conversation
Member
|
@i-am-fyre @Meltie2013 - I'd appreciate some eyes on this build !!
|
Member
|
This is the partner PR to this commit: 1ba32d2 |
Member
|
Actually, it could be related to this: |
seobryn
reviewed
Jul 21, 2022
| uint32 pathLen = sWorld.GetDataPath().length() + strlen("mmaps/%04i.mmap") + 1; | ||
| char* fileName = new char[pathLen]; | ||
| snprintf(fileName, pathLen, (sWorld.GetDataPath() + "mmaps/%03i.mmap").c_str(), mapId); | ||
| snprintf(fileName, pathLen, (sWorld.GetDataPath() + "mmaps/%04i.mmap").c_str(), mapId); |
There was a problem hiding this comment.
This change causes Segmentation Fault because the format is out of bounds
seobryn
reviewed
Jul 21, 2022
| int32 gy = 32 - player->GetPositionY() / SIZE_OF_GRIDS; | ||
|
|
||
| PSendSysMessage("%03u%02i%02i.mmtile", player->GetMapId(), gy, gx); | ||
| PSendSysMessage("%04u%02i%02i.mmtile", player->GetMapId(), gy, gx); |
There was a problem hiding this comment.
this chage causes egmentation fault due to the format on this case is out of bounds
seobryn
reviewed
Jul 21, 2022
seobryn
left a comment
seobryn
left a comment
There was a problem hiding this comment.
The changes that you propose are only aplicable for Map Generator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change is