Skip to content

fix(workflow): Add SKIP_AUTH default value to prevent Pydantic validation errors #643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
manavgup wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(workflow): Add SKIP_AUTH default value to prevent Pydantic validation errors #643

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions .github/workflows/deploy_complete_app.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,9 @@
IBM_CLOUD_REGION: ${{ vars.IBM_CLOUD_REGION || 'us-south' }}
CR_NAMESPACE: ${{ vars.IBM_CR_NAMESPACE || 'rag_modulo' }}
# ICR uses shortened region names: us-south -> us, eu-gb -> uk, ca-tor -> ca, etc.
ICR_REGION: ${{ vars.IBM_CLOUD_REGION == 'eu-gb' && 'uk' || (vars.IBM_CLOUD_REGION == 'us-south' && 'us' || (vars.IBM_CLOUD_REGION == 'us-east' && 'us' || (vars.IBM_CLOUD_REGION == 'ca-tor' && 'ca' || vars.IBM_CLOUD_REGION))) }}
ICR_REGION: ${{ vars.IBM_CLOUD_REGION == 'eu-gb' && 'uk' || (vars.IBM_CLOUD_REGION == 'us-south' && 'us' ||
(vars.IBM_CLOUD_REGION == 'us-east' && 'us' || (vars.IBM_CLOUD_REGION == 'ca-tor' && 'ca' ||
vars.IBM_CLOUD_REGION))) }}

# Prevent concurrent deployments to avoid conflicts
concurrency:
Expand Down Expand Up @@ -341,7 +343,7 @@
APP_NAME: ${{ env.BACKEND_APP_NAME }}
IBM_CLOUD_REGION: ${{ env.IBM_CLOUD_REGION }}
IBM_CLOUD_RESOURCE_GROUP: ${{ vars.IBM_CLOUD_RESOURCE_GROUP || 'rag-modulo-deployment' }}
SKIP_AUTH: ${{ secrets.SKIP_AUTH }}
SKIP_AUTH: ${{ secrets.SKIP_AUTH || 'false' }}
OIDC_DISCOVERY_ENDPOINT: ${{ secrets.OIDC_DISCOVERY_ENDPOINT }}
IBM_CLIENT_ID: ${{ secrets.IBM_CLIENT_ID }}
IBM_CLIENT_SECRET: ${{ secrets.IBM_CLIENT_SECRET }}
Expand Down Expand Up @@ -393,7 +395,7 @@
--max-scale 5 \
--cpu 1 \
--memory 4G \
--env DATABASE_URL="postgresql://$COLLECTIONDB_USER:$COLLECTIONDB_PASS@$COLLECTIONDB_HOST:$COLLECTIONDB_PORT/$COLLECTIONDB_NAME?sslmode=require" \

Check warning on line 398 in .github/workflows/deploy_complete_app.yml

View workflow job for this annotation

GitHub Actions / YAML Lint 

398:121 [line-length] line too long (160 > 120 characters)
--env MILVUS_HOST="$MILVUS_HOST" \
--env MILVUS_PORT="$MILVUS_PORT" \
--env MINIO_ENDPOINT="$MINIO_ENDPOINT" \
Expand All @@ -414,7 +416,7 @@
--cpu 1 \
--memory 4G \
--port 8000 \
--env DATABASE_URL="postgresql://$COLLECTIONDB_USER:$COLLECTIONDB_PASS@$COLLECTIONDB_HOST:$COLLECTIONDB_PORT/$COLLECTIONDB_NAME?sslmode=require" \

Check warning on line 419 in .github/workflows/deploy_complete_app.yml

View workflow job for this annotation

GitHub Actions / YAML Lint 

419:121 [line-length] line too long (160 > 120 characters)
--env MILVUS_HOST="$MILVUS_HOST" \
--env MILVUS_PORT="$MILVUS_PORT" \
--env MINIO_ENDPOINT="$MINIO_ENDPOINT" \
Expand Down Expand Up @@ -521,7 +523,7 @@

- name: Test Backend Health
run: |
BACKEND_URL=$(ibmcloud ce app get --name "${{ env.BACKEND_APP_NAME }}" --output json | jq -r '.status.url' | head -1)

Check warning on line 526 in .github/workflows/deploy_complete_app.yml

View workflow job for this annotation

GitHub Actions / YAML Lint 

526:121 [line-length] line too long (127 > 120 characters)
if [ -n "$BACKEND_URL" ]; then
echo "Testing backend at: $BACKEND_URL/health"
if curl -f -s "$BACKEND_URL/health" > /dev/null; then
Expand All @@ -537,7 +539,7 @@

- name: Test Frontend Health
run: |
FRONTEND_URL=$(ibmcloud ce app get --name "${{ env.FRONTEND_APP_NAME }}" --output json | jq -r '.status.url' | head -1)

Check warning on line 542 in .github/workflows/deploy_complete_app.yml

View workflow job for this annotation

GitHub Actions / YAML Lint 

542:121 [line-length] line too long (129 > 120 characters)
if [ -n "$FRONTEND_URL" ]; then
echo "Testing frontend at: $FRONTEND_URL"
if curl -f -s "$FRONTEND_URL" > /dev/null; then
Expand All @@ -553,8 +555,8 @@

- name: Test Application Integration
run: |
BACKEND_URL=$(ibmcloud ce app get --name "${{ env.BACKEND_APP_NAME }}" --output json | jq -r '.status.url' | head -1)

Check warning on line 558 in .github/workflows/deploy_complete_app.yml

View workflow job for this annotation

GitHub Actions / YAML Lint 

558:121 [line-length] line too long (127 > 120 characters)
FRONTEND_URL=$(ibmcloud ce app get --name "${{ env.FRONTEND_APP_NAME }}" --output json | jq -r '.status.url' | head -1)

Check warning on line 559 in .github/workflows/deploy_complete_app.yml

View workflow job for this annotation

GitHub Actions / YAML Lint 

559:121 [line-length] line too long (129 > 120 characters)
echo "✅ Complete application deployed successfully!"
echo "Backend URL: $BACKEND_URL"
echo "Frontend URL: $FRONTEND_URL"
Expand Down
Loading