Test of new binder API: Find unused definitions #5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrated from Nomic repository to keep track of the branch. The
red-green-treesbranch is not likely to be merged in the near future.To be merged on top of red-green-trees.
It adds as a test case in the cargo-sphere with the example from find-unused-definitions, but using the new binder and output from the backend.
Some functions are almost literal translations. For instance,
collect_definitionsstill uses the cursor. Other functions exploit the information from a typed AST.visit_contractis a good example.It adds a few helper functions:
Binder::navigate_toto flow from an identifier node id to a definition.Definition::nodeto obtain the innerSyntaxNode.SyntaxNode::create_cursor(self-described).astin the backend mod.NOTE: I screw my commits, so they're unparseable on their own. The best way to review it is to just focus on the
test/src/ast_apifolder.