by slashrsm: Add support for comment-wrapped esi tags. #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ESI spec allows comment wrapped ESI tags (i.e. "<!--esi ... -->"), which are ignored by jquery.esi.js. Added support for them.
jquery.esi.js
Outdated
Owner
There was a problem hiding this comment.
It looks like the value 8 has a corresponding named constant COMMENT_NODE ( see http://www.w3schools.com/jsref/prop_node_nodetype.asp ). Could you check if the constant also works correctly in your use-case?
Author
There was a problem hiding this comment.
Unfortunately it does not. I tried it in Chromium 29.0.1547.65 (Ubuntu 13.10) and Firefox 24.0.
Author
|
Do you need any more clarifications about this? |
…utside iframes on page. iframes that pull content from other URLs can cause errors like this: "Blocked a frame with origin "http://web1.dev.examiner.com" from accessing a frame with origin "http://www.facebook.com". The frame being accessed set "document.domain" to "facebook.com", but the frame requesting access did not. Both must set "document.domain" to the same value to allow access." There is no point in looking for esi tags inside iframes anyway so let's exclude them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ESI spec allows comment wrapped ESI tags (i.e. ""), which are ignored by jquery.esi.js. Added support for them.
Spec: http://www.w3.org/TR/esi-lang