Skip to content

Main #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mamadfrhi wants to merge 107 commits into
base: features/architecture
Choose a base branch
from
Open

Main #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
107 commits
Select commit Hold shift + click to select a range
941ea78
api call implemented in Waiting module.
mamadfrhi Apr 11, 2022
04d751b
IBoutlets added to the WaitingVC as well as retry button.
mamadfrhi Apr 11, 2022
63d5b3c
The app now can receives cars Json files from API and convert it to n…
mamadfrhi Apr 11, 2022
97768ac
API errors handled.
mamadfrhi Apr 11, 2022
51ad9bb
api call code cleaned.
mamadfrhi Apr 11, 2022
2816927
error handling improved.
mamadfrhi Apr 11, 2022
1ee7338
retry API call functionality implemented on WaitingVC.
mamadfrhi Apr 11, 2022
38ac51a
Wrote better comments for WaitingVM.
mamadfrhi Apr 11, 2022
4628a45
Design pattern implemented to send received cars in WaitingVM to AppC…
mamadfrhi Apr 11, 2022
5489ebb
coordinate from WaitingVC to TabBarController.
mamadfrhi Apr 12, 2022
e7395be
added MapKit to the View.
mamadfrhi Apr 12, 2022
5b6cb68
MapCarVC implemented.
mamadfrhi Apr 12, 2022
cee8868
MapCars Coordinator delegate handled and the class cleaned a bit.
mamadfrhi Apr 12, 2022
555d56f
MapCarsVM implemented.
mamadfrhi Apr 12, 2022
b65f903
added viewType for car model to encode MKPointAnnotation within them.
mamadfrhi Apr 12, 2022
3d919ea
inject received cars from AppCoordinator to CarsMapViewVM
mamadfrhi Apr 12, 2022
5a31fea
receive retrieved cars from AppCoordinator in MapCarsCoordinator.
mamadfrhi Apr 12, 2022
922f32d
show car annotations on map like a charm! :D
mamadfrhi Apr 12, 2022
e7a3529
fetching each car's image in background implemented.
mamadfrhi Apr 12, 2022
138c2b8
updated image downloader to a UIImageView extension.
mamadfrhi Apr 12, 2022
2e3d0be
removed fetchImages function from waitingView.
mamadfrhi Apr 12, 2022
2196168
Custom annotations to show on MapKitView implemented.
mamadfrhi Apr 12, 2022
c86a068
set navigation title for view controllers
mamadfrhi Apr 12, 2022
4f13594
changed all ViewController names to VC and all ViewModel names to VM …
mamadfrhi Apr 12, 2022
7763e24
ListCars page implemented as well as related files like VM and VC. Ap…
mamadfrhi Apr 12, 2022
fa709af
view model folder of the ListCars page added to the git.
mamadfrhi Apr 12, 2022
74bed69
CarInfoVC implemented to show detail about the selected car.
mamadfrhi Apr 12, 2022
6449aa4
CarModalView implemented to show more info about the selected car.
mamadfrhi Apr 12, 2022
c2cef8d
implemented modal page info for MapCarsVC as well. Cars on the map ar…
mamadfrhi Apr 12, 2022
a24a684
hotfix: code which has been deleted by mistake added.
mamadfrhi Apr 12, 2022
437fb4b
codes related to make annotations for mapView cleaned.
mamadfrhi Apr 13, 2022
f469cda
cleaned code of making annotation view function in MapCarsVM.
mamadfrhi Apr 13, 2022
c304339
Merge pull request #3 from mamadfrhi/clean_code
mamadfrhi Apr 13, 2022
91e4ad3
removed unlogical casting in MapCarsVM
mamadfrhi Apr 13, 2022
fa066df
cleaned folder structure of CarModalView page.
mamadfrhi Apr 13, 2022
4caaaaf
improved code readability of WaitingVM.
mamadfrhi Apr 13, 2022
8edb191
improved code readability of WaitingVC.
mamadfrhi Apr 13, 2022
b134304
cleaned AppCoordinator.swift file.
mamadfrhi Apr 13, 2022
3af3b98
cleaned TODO comments of MapCarsCoordinator.swift file
mamadfrhi Apr 13, 2022
be9667c
cleaned MapCars module files.
mamadfrhi Apr 13, 2022
543bc01
renamed VM abstraction file of ListCars module to a more sensible name.
mamadfrhi Apr 13, 2022
1e00311
made api client reference weak to prevent retain cycle.
mamadfrhi Apr 13, 2022
d2fcf9a
no internet scenario and related error shown to the user on WaitingVC…
mamadfrhi Apr 13, 2022
166396d
improved code readability.
mamadfrhi Apr 13, 2022
0c0e682
applied SRP on MapCarsVM and injected cars array as dependency to it.
mamadfrhi Apr 13, 2022
514926a
prevent double start at MapCarsCoordinator.
mamadfrhi Apr 13, 2022
a8c2602
cleaned ListCars module's code and deleted unnecessary functions.
mamadfrhi Apr 13, 2022
b3d493f
cleaning on MapCars module.
mamadfrhi Apr 13, 2022
19173fc
Merge branch 'develop'
mamadfrhi Apr 13, 2022
bb556a2
null state for car images handled on api request.
mamadfrhi Apr 13, 2022
c11c76d
Used Sixt color codes to change appearance of the main controls and a…
mamadfrhi Apr 13, 2022
9890110
made modal page's textview uneditable.
mamadfrhi Apr 13, 2022
f143d89
Merge branch 'improve_ui_ux'
mamadfrhi Apr 13, 2022
f412237
test bundle added to the app.
mamadfrhi Apr 13, 2022
3fde71f
cleaned unused array from WaitingVM.
mamadfrhi Apr 14, 2022
bd27502
tests written to check VC titles and tabbar badge value
mamadfrhi Apr 14, 2022
33fd3ec
Merge branch 'develop'
mamadfrhi Apr 14, 2022
16a9588
used factory design pattern to init MapCarsVC.
mamadfrhi Apr 14, 2022
2ea6b27
changed name of the factory function.
mamadfrhi Apr 14, 2022
d06bfcf
applied factory design pattern to init CarsListVC.
mamadfrhi Apr 14, 2022
048fb14
improved factory pattern for MapCarVC.
mamadfrhi Apr 14, 2022
c371538
improved interface of table view which shows list of cars.
mamadfrhi Apr 14, 2022
9c27681
changed icons of tabBars to more sensible images
mamadfrhi Apr 14, 2022
f3d7567
used factory design pattern in cleaner approach.
mamadfrhi Apr 14, 2022
7d57d05
implemented factory design pattern for WaitingVC.
mamadfrhi Apr 14, 2022
5406153
write a test to check count of tabbars
mamadfrhi Apr 14, 2022
b02b417
cleared unnecessary comments.
mamadfrhi Apr 14, 2022
ff86c74
implemented unit test for tableView on page ListCars.
mamadfrhi Apr 15, 2022
1096c76
fixed 2 code mistakes on ListCarsVC.
mamadfrhi Apr 15, 2022
d23ad4e
implemented GWT unit test for ListCars ViewModel.
mamadfrhi Apr 15, 2022
3fa6009
cleaned testTableView with GWT testing comments.
mamadfrhi Apr 15, 2022
e2200e2
cleaned testListCarsVM test function.
mamadfrhi Apr 15, 2022
67e227d
refactor and structured tabbar controller to GWT.
mamadfrhi Apr 15, 2022
f2b0c8f
enrich test with logical comments for better understanding.
mamadfrhi Apr 15, 2022
c591926
added a todo reminder for testing.
mamadfrhi Apr 15, 2022
602daff
implemented Service layer to the project.
mamadfrhi Apr 15, 2022
778135b
added todo reminder for testing newly added Service Layer.
mamadfrhi Apr 15, 2022
f403555
readme.md added + diagram of the app architecture added + code base m…
mamadfrhi Apr 15, 2022
f9791a7
Merge pull request #4 from mamadfrhi/visualization
mamadfrhi Apr 15, 2022
3591df5
readme file updated.
mamadfrhi Apr 15, 2022
1a7de43
architecture diagram added to the project.
mamadfrhi Apr 15, 2022
f7fcdd1
updated readme file and the diagram.
mamadfrhi Apr 15, 2022
664565d
updated readme
mamadfrhi Apr 15, 2022
bd2574b
added video on readme
mamadfrhi Apr 15, 2022
590241d
updated readme
mamadfrhi Apr 15, 2022
9fe98d7
Update readme.md
mamadfrhi Apr 15, 2022
5dc1df6
Update readme.md
mamadfrhi Apr 15, 2022
b66dfc1
Merge pull request #5 from mamadfrhi/visualization
mamadfrhi Apr 15, 2022
3c004c1
cleaning on AppCoordinator
mamadfrhi Apr 15, 2022
81a835b
cleaning on Car model
mamadfrhi Apr 15, 2022
3a32028
used correct access modifiers and removed unnecessary codes.
mamadfrhi Apr 15, 2022
c6aaa1a
made coordinate property constant.
mamadfrhi Apr 15, 2022
0d153b8
converted var variables to let variables if it's possible. converted …
mamadfrhi Apr 15, 2022
a39a94f
moved location of the function for better readability.
mamadfrhi Apr 17, 2022
4fd65f8
removed datasource and tableview delegate from class and outsourced o…
mamadfrhi Apr 17, 2022
e29e2da
reminder comment for annotationView improvement.
mamadfrhi Apr 17, 2022
59c7d04
converted ApiClass to the struct to prevent from retain cycle.
mamadfrhi Apr 17, 2022
5954080
moved table view cell initilization from VM to VC.
mamadfrhi Apr 17, 2022
2c8abfa
moved UI related code from VM to VC.
mamadfrhi Apr 17, 2022
1afb93b
improve showing annotation views.
mamadfrhi Apr 18, 2022
d51353c
to respect to DRY principle and improvement in internet usage, UIImag…
mamadfrhi Apr 19, 2022
1e959a3
fixed typo
mamadfrhi Apr 19, 2022
b87fe43
adapt Unit Tests with new changes.
mamadfrhi Apr 19, 2022
2a215b0
updated video of readme file.
mamadfrhi Apr 30, 2022
41c6c74
Update readme.md
mamadfrhi Jul 12, 2024
9a88f31
Update readme.md
mamadfrhi Jul 12, 2024
1f5bc10
Update readme.md
mamadfrhi Jul 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 0 additions & 14 deletions Cars Map.xcodeproj/xcuserdata/mamadfarrahi.xcuserdatad/xcschemes/xcschememanagement.plist
View file
Open in desktop

This file was deleted.

66 changes: 0 additions & 66 deletions Cars Map/Scenes/AppCoordinator.swift
View file
Open in desktop

This file was deleted.

11 changes: 0 additions & 11 deletions Cars Map/Scenes/Car.swift
View file
Open in desktop

This file was deleted.

38 changes: 0 additions & 38 deletions Cars Map/Scenes/ListCars/ListCarsCoordinator.swift
View file
Open in desktop

This file was deleted.

33 changes: 0 additions & 33 deletions Cars Map/Scenes/ListCars/View/ListCars.storyboard
View file
Open in desktop

This file was deleted.

10 changes: 0 additions & 10 deletions Cars Map/Scenes/ListCars/ViewController/ListCarsVC.swift
View file
Open in desktop

This file was deleted.

38 changes: 0 additions & 38 deletions Cars Map/Scenes/MapCars/MapCarsCoordinator.swift
View file
Open in desktop

This file was deleted.

33 changes: 0 additions & 33 deletions Cars Map/Scenes/MapCars/View/MapCars.storyboard
View file
Open in desktop

This file was deleted.

10 changes: 0 additions & 10 deletions Cars Map/Scenes/MapCars/ViewController/MapCarsVC.swift
View file
Open in desktop

This file was deleted.

Loading