Fix convertToInt() rejecting integers with whitespace#27
Merged
maltehuebner merged 2 commits intomainfrom Mar 14, 2026
Merged
Conversation
External API consumers occasionally send integer parameters with leading or trailing whitespace (e.g. " 1711922400"), causing an InvalidArgumentException. Adding trim() before the regex check fixes this. Refs #24 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Verifies that integer values with leading/trailing whitespace are accepted for both query and parameter assignments. Closes #24 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
trim()inValueAssigner::convertToInt()before the regex check, so integer values with leading/trailing whitespace (e.g." 1711922400") are accepted instead of throwing anInvalidArgumentExceptionContext
External API consumers occasionally send parameters with whitespace, causing
InvalidArgumentException: Parameter "fromDateTime" is not a valid integer: " 1711922400". See criticalmass-one/criticalmass-in#1299.Test plan
testConvertToIntTrimsWhitespace— query int with leading whitespacetestConvertToIntTrimsWhitespaceForParameter— parameter int with surrounding whitespaceCloses #24
🤖 Generated with Claude Code