Save and restore scroll-position for multiple lists#24
Save and restore scroll-position for multiple lists#24Traxmaxx wants to merge 13 commits intomallzee:12-scroll-positionfrom meltwater:12-scroll-position
Conversation
Enable scrollbars on Android
|
Added another commit to be able to reset the scroll position. I'm not really happy messing around with the users scope though. Maybe you have a better idea? : ) |
|
Tests are fixed. Unfortunately he's only running 2 of them. Running "karma:continuous" (karma) task
INFO [reporter.osx]: OSX Notification Center reporter started at http://localhost:1337
INFO [karma]: Karma v0.10.10 server started at http://localhost:9876/
INFO [launcher]: Starting browser PhantomJS
WARN [watcher]: Pattern "/Users/traxmaxx/angular-ui-table-view/bower_components/iscroll/build/iscroll-probe.js" does not match any file.
INFO [PhantomJS 1.9.7 (Mac OS X)]: Connected on socket A9UfF0wzcg7Ejgxs12ts
LOG: 'Restoring', 0
LOG: 'Restoring', 0
.
LOG: 'Restoring', 0
LOG: 'Restoring', 0
.
PhantomJS 1.9.7 (Mac OS X): Executed 2 of 2 SUCCESS (0.132 secs / 0.002 secs)
Done, without errors.Is this correct? Can I remove iScroll from |
|
Ahh yea iScroll can be taken out now. Sorry will look over this properly shortly. |
Adds the main files definition (useful when using tools such as bower-install)
Add main definition
|
Any update on my thoughts? : ) |
|
Hi Alex, Sorry I've been away over easter and am just catching up with this now! Yes these make sense! I am looking at this along with one of the guys at Ionic, so there's a chance my thoughts could change. As they make use of services and delegates to control this sort of thing which could be the way forward. |
|
No worries : ) Is there a thread or issue where I can follow the discussion? |
|
It wasn't much and it was by email @Traxmaxx. They actually just released their version of a virtular scroller in beta2 of the ionic framework. I had a quick play with it and it looks pretty awesome. |
|
Ah, ok. Got the scroll caching working successfully yesterday with our app. I did many manual fixes currently and needed to add some of the changes from |
|
There you go : ) |
Traxmaxx
changed the title
|
@Traxmaxx very cool, looking forward to the merge! |
|
Right, back in the game. Lets take a look at this 💃 |
|
\o/ |
|
So, what's the status? Should I take care of merging the fixes? |
3 participants
Finally made it to have a look at the scroll caching : )
Just a small improvement: you're now able to give your list a custom id through viewParams