Validating buffer for short lists and improper redundant renderers deletion.#15
Open
chudesno wants to merge 5 commits intomallzee:masterfrom
Open
Validating buffer for short lists and improper redundant renderers deletion.#15chudesno wants to merge 5 commits intomallzee:masterfrom
chudesno wants to merge 5 commits intomallzee:masterfrom
Conversation
Updating buffer.bottom in the case when there are not enough items in the list.
Member
|
@chudesno Thanks for another PR! I've just been working on the same problem. Can you checkout the latest master branch and see if this PR is still required? Cheers, |
Contributor
|
Works fine for me with the latest master branch. |
Update to original
Loop index does not get decreased when item is deleted
The case was handled earlier in original repo
Contributor
Author
|
You are right. The nagative value in the buffer.top is fixed in your commit. However there seems to be an issue with items deletion when the list becomes shorter. Could you review my fix and tell if it makes sense? |
chudesno
changed the title
Member
|
Will try this out shortly! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Things get messed when there are not enough items in the list. If we use '<', the buffer.top might be set to a negative value.