qml: Remove the swipe-to-close feature of the keyboard#157
qml: Remove the swipe-to-close feature of the keyboard#157dobey wants to merge 1 commit intomaliit:masterfrom
Conversation
4fa912f to
cb09da6
Compare
cb09da6 to
fbe4250
Compare
fbe4250 to
2a0babe
Compare
espidev
left a comment
There was a problem hiding this comment.
I worry if this would have an impact on Lomiri, in Plasma Mobile we have a keyboard close button, is that something that exists there?
There have been numerous problems with this interaction over the years, and the implementation to make swipe to close work is a bit spread around. One consistent issue has been the keyboard getting stuck partly closed, and swiping upward does nothing, while in some cases swiping upward could also cause the keyboard to be moved partially off the screen. This implementation would also be in conflict of possible implementation of skeyer swipe support in the future. So just remove it for now.
Ubuntu Touch still uses lomiri-keyboard, so this doesn't effect that. One can also just tap literally anywhere else in an app, and the keyboard should close, once whatever focused input field loses focus. |
|
Any thoughts on perhaps replacing the logic with: #211 instead? I think it works well in avoiding the need to resize the keyboard window while still retaining the gesture, which can resolve the initial issue with half-finished gestures and the like. |
There have been numerous problems with this interaction over the years,
and the implementation to make swipe to close work is a bit spread around.
One consistent issue has been the keyboard getting stuck partly closed, and
swiping upward does nothing, while in some cases swiping upward could also
cause the keyboard to be moved partially off the screen. This implementation
would also be in conflict of possible implementation of skeyer swipe support
in the future. So just remove it for now.