Dispatch directly with function pointer address instead of lookup through table#186
Draft
malcolmstill wants to merge 5 commits intomasterfrom
Draft
Dispatch directly with function pointer address instead of lookup through table#186malcolmstill wants to merge 5 commits intomasterfrom
malcolmstill wants to merge 5 commits intomasterfrom
Conversation
8676bb8 to
5a2ebec
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
instructionsarray and populates it at module parse time alongside theparsed_codearray.Note: I had some issues with a recursive definition for
InstructionFunctionso I added a similar dummy type and do some casting which is a bit ugly.Problem
Looking at the machine code for a few instructions we might expect this change to give us some speed increase, as the instruction count seems to have come down (as we might have expected from getting rid of a superfluous table lookup), but
fibactually takes longer to run with this change. Why could that be?nop
Before:
After:
else
Before:
After: