feat: Add SNP feature matrix helper function for ML workflows (Issue #1185)#1248
Open
janhavitupe wants to merge 1 commit intomalariagen:masterfrom
Open
feat: Add SNP feature matrix helper function for ML workflows (Issue #1185)#1248janhavitupe wants to merge 1 commit intomalariagen:masterfrom
janhavitupe wants to merge 1 commit intomalariagen:masterfrom
Conversation
- Add snp_feature_matrix() method to AnophelesSnpFrequencyAnalysis class - Supports both cohort mode (one row per cohort) and sample mode (one row per sample) - Returns DataFrame with columns: total_snp_count, nonsynonymous_snp_count, mean_allele_frequency - Uses existing public methods: snp_allele_frequencies() and snp_genotype_allele_counts() - Add comprehensive test suite with 5 test functions covering all scenarios - Remove unnecessary comments for cleaner codebase - All code quality checks pass (ruff, py_compile) Fixes malariagen#1185
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
snp_feature_matrixmethod in AnophelesSnpFrequencyAnalysis classImplementation Details
snp_feature_matrix()with full parameter support_snp_feature_matrix_cohort_mode()and_snp_feature_matrix_sample_mode()total_snp_count,nonsynonymous_snp_count,mean_allele_frequencyTesting
Code Quality
Fixes #1185