Improve robustness of cohort diversity statistics and make cache version easier to manage#1246
Open
Vibhanshu230 wants to merge 1 commit intomalariagen:masterfrom
Open
Improve robustness of cohort diversity statistics and make cache version easier to manage#1246Vibhanshu230 wants to merge 1 commit intomalariagen:masterfrom
Vibhanshu230 wants to merge 1 commit intomalariagen:masterfrom
Conversation
… cohot version constant so cache entries can be safely invalidated
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes a few small improvements to cohort_diversity_stats() to make the function more robust and easier to maintain.
These changes do not affect the expected outputs in normal cases, but help prevent edge-case errors and make the cache behaviour clearer. I am happy to adjust the implementation if there is a preferred style for validation or cache versioning in this module.