feat: add Pippin shell action button to worktree launch buttons#16
Merged
Conversation
|
🎉 This PR is included in version 2.10.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a new action button to each worktree card that opens a Ghostty terminal tab running
pippin shelldirectly in the worktree directory. The button is only shown whenpippinis available on the user's PATH.Changes
launch:pippinShellRPC request and bun-side handlerlaunchPippinShell()launcher that resolves thepippinbinary via the login-shell env, then opens a Ghostty tab withcommandset to the resolved path and the login-shellPATHinjected as an environment variable (so tools likedockerare available inside the session)system:pippinPathRPC that probeswhich pippinat startupLaunchButtonscomponent probessystem:pippinPathon mount and conditionally renders the button usingIconPrisonTesting
bun run test— 25 test files, 64 tests, all passingbun run typecheck— cleanpippin shellin the correct worktree directory; exiting Pippin closes the tab rather than dropping back to the default shell; button is hidden whenpippinis not installedReviewer Notes
The launcher resolves the absolute
pippinbinary path viawhich pippinusing the login-shell environment before constructing the AppleScript, because Ghostty's GUI process runs with a stripped PATH. The login-shell PATH is also forwarded as a surface environment variable so subprocesses spawned by Pippin (e.g.docker) can be found.