Skip to content

Comments

chore: add test for same frame callback#520

Merged
makspll merged 1 commit intomainfrom
chore/same-frame-callback-test
Feb 11, 2026
Merged

chore: add test for same frame callback#520
makspll merged 1 commit intomainfrom
chore/same-frame-callback-test

Conversation

@makspll
Copy link
Owner

@makspll makspll commented Feb 10, 2026

Summary

I think we don't expect callbacks to happen in this case, since sweeping "for all" events definitely don't want to be re-queued

# Summary
I think we don't expect callbacks to happen in this case, since sweeping "for all" events definitely don't want to be re-queued
@semanticdiff-com
Copy link

semanticdiff-com bot commented Feb 10, 2026

Review changes with  SemanticDiff

Changed Files
File Status
  Cargo.toml Unsupported file format
  assets/tests/lifecycle/default/static_script/same_frame_callback/callback.lua  0% smaller
  assets/tests/lifecycle/default/static_script/same_frame_callback/scenario.txt Unsupported file format

@github-actions
Copy link
Contributor

🐰 Bencher Report

Branchchore/same-frame-callback-test
Testbedlinux-gha

⚠️ WARNING: No Threshold found!

Without a Threshold, no Alerts will ever be generated.

Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the --ci-only-thresholds flag.

Click to view all benchmark results
BenchmarkLatencynanoseconds (ns)
component/access Lua📈 view plot
⚠️ NO THRESHOLD
6,119.60 ns
component/access Rhai📈 view plot
⚠️ NO THRESHOLD
9,334.50 ns
component/get Lua📈 view plot
⚠️ NO THRESHOLD
3,154.40 ns
component/get Rhai📈 view plot
⚠️ NO THRESHOLD
7,965.80 ns
conversions/Mut::from📈 view plot
⚠️ NO THRESHOLD
85.59 ns
conversions/Ref::from📈 view plot
⚠️ NO THRESHOLD
82.21 ns
conversions/ScriptValue::List📈 view plot
⚠️ NO THRESHOLD
470.14 ns
conversions/ScriptValue::Map📈 view plot
⚠️ NO THRESHOLD
1,125.30 ns
conversions/ScriptValue::Reference::from_into📈 view plot
⚠️ NO THRESHOLD
24.77 ns
conversions/Val::from_into📈 view plot
⚠️ NO THRESHOLD
243.64 ns
function/call 4 args Lua📈 view plot
⚠️ NO THRESHOLD
2,007.30 ns
function/call 4 args Rhai📈 view plot
⚠️ NO THRESHOLD
1,488.00 ns
function/call Lua📈 view plot
⚠️ NO THRESHOLD
387.57 ns
function/call Rhai📈 view plot
⚠️ NO THRESHOLD
447.35 ns
loading/empty Lua📈 view plot
⚠️ NO THRESHOLD
1,226,700.00 ns
loading/empty Rhai📈 view plot
⚠️ NO THRESHOLD
1,299,600.00 ns
math/vec mat ops Lua📈 view plot
⚠️ NO THRESHOLD
10,165.00 ns
math/vec mat ops Rhai📈 view plot
⚠️ NO THRESHOLD
9,200.70 ns
query/10 entities Lua📈 view plot
⚠️ NO THRESHOLD
22,636.00 ns
query/10 entities Rhai📈 view plot
⚠️ NO THRESHOLD
29,707.00 ns
query/100 entities Lua📈 view plot
⚠️ NO THRESHOLD
41,548.00 ns
query/100 entities Rhai📈 view plot
⚠️ NO THRESHOLD
43,175.00 ns
query/1000 entities Lua📈 view plot
⚠️ NO THRESHOLD
264,010.00 ns
query/1000 entities Rhai📈 view plot
⚠️ NO THRESHOLD
182,780.00 ns
reflection/10 Lua📈 view plot
⚠️ NO THRESHOLD
5,469.80 ns
reflection/10 Rhai📈 view plot
⚠️ NO THRESHOLD
15,171.00 ns
reflection/100 Lua📈 view plot
⚠️ NO THRESHOLD
46,537.00 ns
reflection/100 Rhai📈 view plot
⚠️ NO THRESHOLD
678,360.00 ns
resource/access Lua📈 view plot
⚠️ NO THRESHOLD
3,554.00 ns
resource/access Rhai📈 view plot
⚠️ NO THRESHOLD
8,787.80 ns
resource/get Lua📈 view plot
⚠️ NO THRESHOLD
2,666.50 ns
resource/get Rhai📈 view plot
⚠️ NO THRESHOLD
7,441.10 ns
🐰 View full continuous benchmarking report in Bencher

@makspll makspll merged commit 4e9960e into main Feb 11, 2026
25 checks passed
@makspll makspll deleted the chore/same-frame-callback-test branch February 11, 2026 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant