Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is working and all tests are passing.
There are diagrams in design.md that show the class relationships, as well as how I broke down the concepts of bowling scores to help me understand how to implement the logic.
It does some basic input validation to stop the user entering anything other than a number, 'X', or '/'. It also tries to stop them entering illogical scores (e.g. a spare on ball one of a frame). It's not yet checking for other issues though (you could enter a score > 10 for example).
I'm pretty pleased with the way the classes interact. I initially planned to store all the scores in a hash table, but having each frame as an instance of Frame means that creating methods like .strike? to check if there's a strike in a frame is really easy.
I also ended up implementing a properly-formatted score sheet to display the output. This may still be a bit flaky and isn't properly tested yet. Lining up all those characters was fun 😂