Open
Conversation
ManuelaIacobovici
left a comment
ManuelaIacobovici
left a comment
There was a problem hiding this comment.
Very well written code overall. Great job!
| @@ -0,0 +1,34 @@ | |||
| class Scoreboard | |||
| def initialize | |||
There was a problem hiding this comment.
Maybe we should initialise with a collection of rolls.
| # can calculate the score | ||
| end | ||
|
|
||
| def roll(pins) |
There was a problem hiding this comment.
We are not calling this function anywhere in the code.
| class Scoreboard | ||
| def initialize | ||
| @rolls = [] # array that will store down number of knocked pins after each roll | ||
| @current_roll = 0 #to keep track of the current roll. Initalising means it is ready to take information so it |
There was a problem hiding this comment.
This could be maybe a reference to the frame, once we detect that we should move to the next frame. It is not used in the code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.