Solmaz's partially completed bowling challenge#398
Open
bookloversolmaz wants to merge 5 commits intomakersacademy:mainfrom
Open
Solmaz's partially completed bowling challenge#398bookloversolmaz wants to merge 5 commits intomakersacademy:mainfrom
bookloversolmaz wants to merge 5 commits intomakersacademy:mainfrom
Conversation
bookloversolmaz
changed the title
tomcarmichael
left a comment
tomcarmichael
left a comment
There was a problem hiding this comment.
Looks like a really good start and I i like the approach to calculating strikes and spares with FX notation
| expect(score.score_count(0)).to eq(0) | ||
| end | ||
|
|
||
| context "players score less than 10 in single frame" do |
There was a problem hiding this comment.
nice use of context to make the test readable as documentation
| context "players score less than 10 in single frame" do | ||
| it "adds the score 3 to counter which is at 0" do | ||
| score = Score.new | ||
| score.score_count(3) |
There was a problem hiding this comment.
perhaps line 13 is not necessary here
| score = Score.new | ||
| score.score_count(5) | ||
| score.score_count(3) | ||
| expect(score.score_count(8)).to eq (8) |
There was a problem hiding this comment.
could perhaps create a new method with no args to just read the score for testing as this may be a self fulfilling test at the moment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.