Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: OpenTelemetry (OTel) observability for the community API #9419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: preview
Are you sure you want to change the base?
Uh oh!
There was an error while loading. Please reload this page.
feat: OpenTelemetry (OTel) observability for the community API #9419
Changes from all commits
810b8c8cd3f004bd331a65514160b8b5f5d38306e3File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎯 Functional Correctness | 🟠 Major | ⚡ Quick win
_OTEL_LOG_ENABLEDtruthy check is inconsistent withconfigure_otel()'s_is_enabled().The celery.py gate accepts
("1", "true", "yes")after.strip().lower(), butconfigure_otel()treats"on"and"ON"as enabled (pertest_truthy_values_for_otel_enabled). SettingOTEL_ENABLED=onwould enable tracing and instrumentation but silently skip trace-correlated logging, defeating log-trace correlation. The comment at line 35 acknowledges the mismatch but doesn't resolve it.🔧 Proposed fix: add `"on"` to the truthy tuple
The same fix should be applied to the Django LOGGING gate in
plane/settings/local.pyandplane/settings/production.py, which the comment says uses the same check. Consider extracting the truthy check into a shared helper inplane.observability.setupto prevent future drift.📝 Committable suggestion
🤖 Prompt for AI Agents
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.